Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

komga: 1.15.0 -> 1.15.1 #367281

Merged
merged 3 commits into from
Jan 2, 2025
Merged

komga: 1.15.0 -> 1.15.1 #367281

merged 3 commits into from
Jan 2, 2025

Conversation

tebriel
Copy link
Contributor

@tebriel tebriel commented Dec 22, 2024

https://github.com/gotson/komga/releases/tag/1.15.1

Also update JDK from 17 to 23

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 22, 2024
@tebriel tebriel marked this pull request as ready for review December 22, 2024 03:46
@ofborg ofborg bot requested a review from GovanifY December 22, 2024 17:56
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-linux: 1 labels Dec 22, 2024
ambroisie
ambroisie requested changes Dec 22, 2024
View reviewed changes
Copy link
Contributor

@ambroisie ambroisie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits, also since you want to add yourself as maintainer, I'd appreciate if you reviewed #345594.

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/by-name/ko/komga/package.nix Outdated Show resolved Hide resolved
@github-actions github-actions bot added 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` and removed 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jan 2, 2025
ambroisie
ambroisie requested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@ambroisie ambroisie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase your maintainers: add tebriel commit before using it in the package definition.

pkgs/by-name/ko/komga/package.nix Show resolved Hide resolved
@tebriel tebriel requested a review from ambroisie January 2, 2025 21:02
@ambroisie ambroisie merged commit 6885774 into NixOS:master Jan 2, 2025
24 of 25 checks passed
@tebriel tebriel deleted the update-komga branch January 2, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambroisie ambroisie ambroisie approved these changes

@GovanifY GovanifY Awaiting requested review from GovanifY

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tebriel @ambroisie